Skip to content

Conversation

@fchapoton
Copy link
Contributor

clean after #38184, closed in 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.

@vincentmacri
Copy link
Member

I think you accidentally included your commit from #41541 on this branch.

@fchapoton
Copy link
Contributor Author

indeed, sorry. fixed now

@vincentmacri
Copy link
Member

LGTM. Unless CI finds something wrong I'll set to positive review.

@vincentmacri
Copy link
Member

There are indeed relevant failures. Make sure to remove the deprecated methods from the corresponding .pyd files as well. Also from the .pyi files, although CI doesn't check it for .pyi files.

@github-actions
Copy link

Documentation preview for this PR (built with commit 2bc6769; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 31, 2026
sagemathgh-41542: Deprec after 38184
    
clean after sagemath#38184, closed in 2024

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
    
URL: sagemath#41542
Reported by: Frédéric Chapoton
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants